Cronet: set clang_use_default_sample_profile via GN arg declaration

At the time clang_use_default_sample_profile was introduced, there was
no GN arg to define whether Cronet was being built. Now that this
exists it's preferable to rely on that instead of override.

Additionally, now that we have dropped all GN arg overrides for Cronet
bots (expect for is_cronet_build), make it clear that no new overrides
should ever be added.

Bug: 40287068
Change-Id: Icddc5a5edd1f2743d33e3db0d1012cffdf9fdd74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6964624
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Reviewed-by: Etienne Dechamps <edechamps@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1517940}
NOKEYCHECK=True
GitOrigin-RevId: f75f73e29564944dd1b2df4d5a8258779463cf4e
2 files changed
tree: 45769302a27b0d567879d70b1a6ce1a55708b851
  1. docs/
  2. lib/
  3. mb_config_expectations/
  4. __init__.py
  5. DIR_METADATA
  6. mb
  7. mb.bat
  8. mb.py
  9. mb_config.pyl
  10. mb_unittest.py
  11. mb_validation_unittest.py
  12. OWNERS
  13. PRESUBMIT.py
  14. README.md
  15. rts_banned_suites.json
README.md

MB - The Meta-Build wrapper

MB is a simple wrapper around the GN build tool.

It was originally written as part of the GYP->GN migration, in order to provide a uniform interface to either GYP or GN, such that users and bots can call one script and not need to worry about whether a given bot was meant to use GN or GYP.

It eventually grew additional functionality and is now still used even though everything is GN-only.

It supports two main functions:

  1. “gen” - the main gn gen invocation that generates the Ninja files needed for the build.

  2. “analyze” - the step that takes a list of modified files and a list of desired targets and reports which targets will need to be rebuilt.

We also use MB as a forcing function to collect all of the different build configurations that we actually support for Chromium builds into one place, in //tools/mb/mb_config.pyl.

For more information, see: