Google Git
Sign in
chromium / chromium / src / 743aa3c7b9eddf0787f93ee2e2388cc71dea5d09
commit743aa3c7b9eddf0787f93ee2e2388cc71dea5d09[log] [tgz]
authorSimon Knott <simon.knott@microsoft.com>Wed Jul 16 22:20:51 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 16 22:20:51 2025
tree30b15b13550efa6f038c22338afb11783d966a89
parent03cdd4b044c1276339cb17d030cbf7e12d9af34f [diff]
[CDP] Detect `Page.navigate` download

Before this CL, navigating to a download URL yields "net::ERR_ABORTED",
and is impossible to distinguish from any other error.
To determine whether the error stems from a download,
one needs to wait for the `Browser.downloadWillBegin` event.
But since that can be emitted *after* `Page.navigate` returns,
this introduces unnecessary waiting.

To prevent this waiting, this CL adds a flag that
shows whether the navigation turned into a download.

Change-Id: I90d81d289df6621d0cdb977ba6ed7e7d74ee475e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6696011
Commit-Queue: Yury Semikhatsky <yurys@chromium.org>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1487924}
8 files changed
tree: 30b15b13550efa6f038c22338afb11783d966a89
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. signing_keys
  53. v8
  54. .clang-format
  55. .clang-tidy
  56. .clangd
  57. .cursorignore
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.